extendObservable: remove constraint for existing property #2252
+245
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davefeucht
changed the title
danielkcz
reviewed
Jan 9, 2020
mweststrate
reviewed
Jan 9, 2020
mweststrate
reviewed
Jan 9, 2020
mweststrate
reviewed
Jan 9, 2020
mweststrate
approved these changes
Jan 9, 2020
|
Yeah, I actually specifically need it for Mobx4 :) |
|
Do you have an idea how long until it will be released, by the way? |
|
I'm a little behind with cutting releases, but early next week should be doable I think. Would that work for you? If interested, feel free to open a PR against mobx4-master as well and cherry-pick the changes (only test and implementation) We are working on making that process smoother😅 |
|
Yeah, early next week should be fine. I’ll make an MR for mobx4-master first thing in the morning with just the code and tests. |
|
THanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently extendObservable throws an error if you try to use it on a property which already exists in the target object/class. This makes it impossible to dynamically make an existing property observable.
/docs. For new functionality, at leastAPI.mdshould be updatednpm run perf)Feel free to ask help with any of these boxes!
The above process doesn't apply to doc updates etc.